[infra] hosts table metrics #173708

klacabane · 2023-12-20T07:52:28Z

Summary

Closes #172475

record performance event of the host table data loading
infra synthtrace now installs system package and can produce all datasets queried by host view
lens viz (internal)

Testing

run journey with PERFORMANCE_ENABLE_TELEMETRY=1 node scripts/run_performance.js -v --journey-path x-pack/performance/journeys/infra_hosts_view.ts
check data is ingested in lens

apmmachine · 2023-12-20T07:52:41Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
/oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

klacabane · 2023-12-26T11:50:31Z

/ci

…fix'

klacabane · 2023-12-26T15:51:36Z

/ci

elasticmachine · 2023-12-27T11:48:47Z

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

dmlemeshko · 2023-12-28T11:57:41Z

Hi @klacabane

Great work, good to see the new performance journey 🔥 Code LGTM and thanks for adding monitoring chart, I added it to the dashboard and will setup alerting to make sure we got notified whenever journey metrics are changing.

Hope you don't mind a small addition I pushed in 066ae0b
I'm not sure if you have future plans to extend the journey with more performance metrics collected (e.g. metric charts render time), but since we also collect APM data I thought it is good to wait for both table and charts are rendered, not only the first row to be displayed. We can later check if journey run time is getting faster/slower over time.

In the past with the help of perf journey we spotted that suggestion charts in Lens Editor have inconsistent rendering time (and customers were reporting it too), so I think it might it useful to track it.

klacabane · 2023-12-29T09:16:59Z

Hi @dmlemeshko, thanks for the change makes sense to already have the journey baseline include charts. Adding charts load time is planned, do you know if there are any examples of that ?

dmlemeshko · 2023-12-29T14:41:54Z

Adding charts load time is planned, do you know if there are any examples of that ?

You can use Lens Editor EBT instrumentation #163089 as example.

I had a quick look and there are few ways to do it: report duration for each LensWrapper + Metric Chart Wrapper individually (I'm sure I put the startTime incorrectly, but just as an example) and end up with 5 separate events or somehow handle loading state completion for the whole KPIGrid (1 event, optionally with details for each lens metric).

Each team has its own preference regarding events structure and level of details, we only suggest split it into time-to-data & time-to-render to better understand the trends (e.g. slow trend is in data fetching, rendering time remains consistent)

packages/kbn-apm-synthtrace-client/src/lib/infra/host.ts

x-pack/plugins/infra/public/services/telemetry/types.ts

This reverts commit 2344594.

klacabane · 2024-01-10T09:44:37Z

@elastic/obs-ux-logs-team @elastic/obs-ux-infra_services-team still looking for review :)

jennypavlova

LGTM 🚀 I tried it locally, thank you for adding that!

jennypavlova · 2024-01-10T15:02:19Z

x-pack/performance/journeys/infra_hosts_table.ts

+  await kibanaPage.waitForCharts({ count: 5, timeout: 60000 });
+});
+
+export function generateHostsData({


Really nice 🤩 I am happy to see that we can use synthrace for host test data generation 💯

x-pack/performance/journeys/infra_hosts_table.ts

packages/kbn-apm-synthtrace/src/lib/infra/infra_synthtrace_kibana_client.ts

jennypavlova · 2024-01-11T14:55:58Z

x-pack/plugins/infra/public/pages/metrics/hosts/hooks/use_hosts_view.ts

+      telemetry.reportPerformanceMetricEvent(
+        'infra_hosts_table_load',
+        duration,
+        { key1: 'data_load', value1: duration },


After I checked the telemetry cluster again I saw that the duration is available there (passed on line 77) Do we need the value1 in this case (or do we want it because we want to use the data_load key)? I see the same data in the Time Series chart selecting value1 and duration

Right now we only record the data loading duration, I've set it as key1 if we want to extend the event with more metrics (ie render time) but atm using either duration or value1 is similar.

Looking at metrics again I can't find the actual duration of the journey, we get different events associated with the journey (getAllTag, kibana_loaded..) but I'm not sure if one of these actually represents the journey execution time @dmlemeshko do you know how we can get the journey duration ?

kibana-ci · 2024-01-15T11:19:44Z

💚 Build Succeeded

Buildkite Build
Commit: ede719b

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`infra`	1342	1346	+4

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/apm-synthtrace`	34	44	+10

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`infra`	1.3MB	1.3MB	+483.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`infra`	99.7KB	99.8KB	+169.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/apm-synthtrace`	34	44	+10

History

💛 Build #187186 was flaky 95b0b2d
💛 Build #187046 was flaky a6ac829
💚 Build #186961 succeeded 2bee796
💛 Build #186773 was flaky c6d80a1
💚 Build #186616 succeeded 954b1e9
💛 Build #186384 was flaky 7ed6817

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

initial impl

5c78e31

klacabane added 6 commits December 21, 2023 14:29

add host.name to synthtrace host documents

65326dc

add more system metricsets to synthtrace

d7c0a84

load 50/500 hosts

d6be806

use querystring to set host limit

b40969e

Merge branch 'main' into 172475-performance-metrics-hosts-view

d754285

Merge branch 'main' into 172475-performance-metrics-hosts-view

799788d

klacabane mentioned this pull request Dec 26, 2023

[asset_manager] Benchmark usage in Hosts view #172475

Open

klacabane added 3 commits December 26, 2023 17:48

infra kibana client to install system package

866b033

add diskio metricset + dimension field

f173687

only run host view step with 500 hosts

ecd2ab9

kibanamachine and others added 3 commits December 26, 2023 11:55

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

9de1787

…fix'

add mock fn

399c5b4

fix tests

e315868

klacabane marked this pull request as ready for review December 27, 2023 11:48

klacabane requested review from a team as code owners December 27, 2023 11:48

Merge branch 'main' into 172475-performance-metrics-hosts-view

4f157da

botelastic bot added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label Dec 27, 2023

klacabane added Feature:Metrics UI Metrics UI feature release_note:skip Skip the PR/issue when compiling release notes labels Dec 27, 2023

jbudz approved these changes Dec 27, 2023

View reviewed changes

update hosts table wait for render, add charts rendering wait in journey

066ae0b

dmlemeshko approved these changes Dec 29, 2023

View reviewed changes

Merge branch 'main' into 172475-performance-metrics-hosts-view

12e9220

miltonhultgren approved these changes Jan 8, 2024

View reviewed changes

packages/kbn-apm-synthtrace-client/src/lib/infra/host.ts Outdated Show resolved Hide resolved

x-pack/plugins/infra/public/services/telemetry/types.ts Show resolved Hide resolved

klacabane added 3 commits January 8, 2024 14:53

use correct dataset

7ed6817

track total render time

2344594

Revert "track total render time"

954b1e9

This reverts commit 2344594.

smith added the apm:review label Jan 9, 2024

record infra source loading

c6d80a1

jennypavlova self-requested a review January 10, 2024 13:47

jennypavlova approved these changes Jan 10, 2024

View reviewed changes

klacabane added 2 commits January 11, 2024 11:33

Merge branch 'main' into 172475-performance-metrics-hosts-view

43e2f73

extract kibana headers

2bee796

jennypavlova reviewed Jan 11, 2024

View reviewed changes

klacabane added 3 commits January 11, 2024 17:55

use same timestamp for synthtrace documents

a6ac829

Merge branch 'main' into 172475-performance-metrics-hosts-view

95b0b2d

Merge branch 'main' into 172475-performance-metrics-hosts-view

ede719b

tonyghiani approved these changes Jan 15, 2024

View reviewed changes

klacabane merged commit a1cd44c into elastic:main Jan 15, 2024
20 checks passed

kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Jan 15, 2024

fkanout mentioned this pull request Jan 17, 2024

[BUG][OBS-UX-MNGT] Metric threshold rule is no longer fetching source #175026

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[infra] hosts table metrics #173708

[infra] hosts table metrics #173708

klacabane commented Dec 20, 2023 •

edited

Loading

apmmachine commented Dec 20, 2023

klacabane commented Dec 26, 2023

klacabane commented Dec 26, 2023

elasticmachine commented Dec 27, 2023

dmlemeshko commented Dec 28, 2023

klacabane commented Dec 29, 2023

dmlemeshko commented Dec 29, 2023

klacabane commented Jan 10, 2024

jennypavlova left a comment

jennypavlova Jan 10, 2024

jennypavlova Jan 11, 2024

klacabane Jan 11, 2024 •

edited

Loading

kibana-ci commented Jan 15, 2024

API count

[infra] hosts table metrics #173708

[infra] hosts table metrics #173708

Conversation

klacabane commented Dec 20, 2023 • edited Loading

Summary

Testing

apmmachine commented Dec 20, 2023

🤖 GitHub comments

klacabane commented Dec 26, 2023

klacabane commented Dec 26, 2023

elasticmachine commented Dec 27, 2023

dmlemeshko commented Dec 28, 2023

klacabane commented Dec 29, 2023

dmlemeshko commented Dec 29, 2023

klacabane commented Jan 10, 2024

jennypavlova left a comment

Choose a reason for hiding this comment

jennypavlova Jan 10, 2024

Choose a reason for hiding this comment

jennypavlova Jan 11, 2024

Choose a reason for hiding this comment

klacabane Jan 11, 2024 • edited Loading

Choose a reason for hiding this comment

kibana-ci commented Jan 15, 2024

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

History

klacabane commented Dec 20, 2023 •

edited

Loading

klacabane Jan 11, 2024 •

edited

Loading